Conversation
|
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
============================================
+ Coverage 91.73% 91.84% +0.10%
- Complexity 106 108 +2
============================================
Files 53 53
Lines 230 233 +3
============================================
+ Hits 211 214 +3
Misses 19 19
☔ View full report in Codecov by Sentry. |
|
@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
|
@l3r8yJ take a look, please |
|
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 2min) |
|
@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
closes #288
PR-Codex overview
This PR adds an
unsubscribemethod to theConsumerinterface and implements it in theKfConsumerandFkConsumerclasses. It also adds TODOs for implementingsubscribe,iterate, andclosemethods in theFkConsumerclass.Detailed summary
unsubscribemethod toConsumerinterfaceunsubscribemethod inKfConsumerandFkConsumersubscribe,iterate, andclosemethods inFkConsumer