Skip to content

Consumer Unsubscribes#291

Merged
rultor merged 5 commits into
masterfrom
288
May 4, 2023
Merged

Consumer Unsubscribes#291
rultor merged 5 commits into
masterfrom
288

Conversation

@h1alexbel

@h1alexbel h1alexbel commented May 4, 2023

Copy link
Copy Markdown
Member

closes #288


PR-Codex overview

This PR adds an unsubscribe method to the Consumer interface and implements it in the KfConsumer and FkConsumer classes. It also adds TODOs for implementing subscribe, iterate, and close methods in the FkConsumer class.

Detailed summary

  • Adds unsubscribe method to Consumer interface
  • Implements unsubscribe method in KfConsumer and FkConsumer
  • Adds TODOs for implementing subscribe, iterate, and close methods in FkConsumer

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself

zoeself commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov

codecov Bot commented May 4, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (a85fa7f) 91.73% compared to head (d78f949) 91.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
+ Coverage     91.73%   91.84%   +0.10%     
- Complexity      106      108       +2     
============================================
  Files            53       53              
  Lines           230      233       +3     
============================================
+ Hits            211      214       +3     
  Misses           19       19              
Impacted Files Coverage Δ
...n/java/io/github/eocqrs/kafka/fake/FkProducer.java 100.00% <ø> (ø)
...va/io/github/eocqrs/kafka/consumer/KfConsumer.java 60.00% <100.00%> (+3.47%) ⬆️
...n/java/io/github/eocqrs/kafka/fake/FkConsumer.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself

zoeself commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-05-07T11:12:19.867366.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel

Copy link
Copy Markdown
Member Author

@l3r8yJ take a look, please

@l3r8yJ l3r8yJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@h1alexbel

Copy link
Copy Markdown
Member Author

@rultor merge

@rultor

rultor commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d78f949 into master May 4, 2023
@h1alexbel h1alexbel deleted the 288 branch May 4, 2023 12:07
@rultor

rultor commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@zoeself

zoeself commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants