Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/io/github/eocqrs/kafka/Consumer.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.time.Duration;
import java.util.Collection;
import java.util.List;

import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;

/**
Expand Down Expand Up @@ -69,4 +70,9 @@ public interface Consumer<K, X> extends Closeable {
* @return Dataized polled data.
*/
List<Dataized<X>> iterate(String topic, Duration timeout);

/**
* Unsubscribe.
*/
void unsubscribe();
}
5 changes: 5 additions & 0 deletions src/main/java/io/github/eocqrs/kafka/consumer/KfConsumer.java
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ public List<Dataized<X>> iterate(final String topic, final Duration timeout) {
return accumulator;
}

@Override
public void unsubscribe() {
this.origin.unsubscribe();
}

@Override
public void close() {
this.origin.close();
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/io/github/eocqrs/kafka/fake/FkConsumer.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ public List<Dataized<X>> iterate(final String topic, final Duration timeout) {
throw new UnsupportedOperationException("#iterate()");
}

@Override
public void unsubscribe() {
throw new UnsupportedOperationException("#unsubscribe()");
}

@Override
public void close() {
throw new UnsupportedOperationException("#close()");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
import io.github.eocqrs.kafka.parameters.KfParams;
import io.github.eocqrs.kafka.parameters.ValueDeserializer;
import io.github.eocqrs.kafka.xml.KfXmlFlexible;

import java.util.Collection;

import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.common.TopicPartition;
Expand All @@ -55,7 +57,7 @@
final class KfConsumerTest {

@Test
void subscribes(
void subscribesWithoutException(
@Mock final ConsumerSettings<String, String> settings,
@Mock final KafkaConsumer<String, String> consumer
) {
Expand All @@ -81,6 +83,18 @@ public void onPartitionsAssigned(final Collection<TopicPartition> partitions) {
);
}

@Test
void unsubscribesWithoutException(
@Mock final ConsumerSettings<String, String> settings,
@Mock final KafkaConsumer<String, String> origin
) {
Mockito.when(settings.consumer()).thenReturn(origin);
final Consumer<String, String> consumer =
new KfConsumer<>(settings);
assertDoesNotThrow(consumer::unsubscribe);
assertDoesNotThrow(consumer::close);
}

@Test
void constructsConsumerWithXML() throws Exception {
final Consumer<String, String> consumer =
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/io/github/eocqrs/kafka/fake/FkConsumerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public void onPartitionsAssigned(final Collection<TopicPartition> partitions) {
UnsupportedOperationException.class,
() -> consumer.iterate("123", Duration.ofMillis(100L))
);
assertThrows(
UnsupportedOperationException.class,
consumer::unsubscribe
);
assertThrows(
UnsupportedOperationException.class,
consumer::close
Expand Down