Skip to content

ISSUE-207 --- Moved twig context alter hook inside the render context… #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DiegoPino merged 1 commit into from
Dec 15, 2023
Merged

ISSUE-207 --- Moved twig context alter hook inside the render context… #392

DiegoPino merged 1 commit into from
Dec 15, 2023

Conversation

@patdunlavey
Copy link
Collaborator

@patdunlavey patdunlavey commented Dec 15, 2023

  • Moved twig context alter hook inside the render context to avoid potential cache 'leakage' errors.

Slack convo: https://archipelagocommons.slack.com/archives/C01A4MPFQA0/p1702663778570049

@DiegoPino DiegoPino merged commit 37b1950 into esmero:1.2.0 Dec 15, 2023
@DiegoPino DiegoPino added enhancement New feature or request Twig Twig template processing metadata Meta(l) data external bug It is not us, it is them labels Dec 15, 2023
@DiegoPino DiegoPino added this to the 1.2.0 milestone Dec 15, 2023
This was referenced Dec 15, 2023
Merged
Open
@patdunlavey patdunlavey deleted the ISSUE-207 branch December 15, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoPino DiegoPino DiegoPino approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request external bug It is not us, it is them metadata Meta(l) data Twig Twig template processing

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@patdunlavey @DiegoPino