ISSUE-207-1.3 --- Moved twig context alter hook inside the render con… #393
Conversation
…text to avoid potential cache 'leakage' errors.
DiegoPino
left a comment
DiegoPino
left a comment
There was a problem hiding this comment.
Small change. Not a biggie but just bc in the future executeInRenderContext might change signature and not return an empty array. Thanks
| // In case someone decided to wipe the original context? | ||
| // We bring it back! | ||
| $context = $context + $original_context; | ||
| $cacheabledata = []; |
There was a problem hiding this comment.
@patdunlavey can you keep please $cacheabledata = []; in line 281?
There was a problem hiding this comment.
I'm afraid I don't understand. Restoring it to a position before $this->renderer->executeInRenderContext will simply result in it being overwritten, and putting it after will clobber the result of $this->renderer->executeInRenderContext, and putting it inside the inline function does nothing that I can see.
There was a problem hiding this comment.
Nevermind. I've gone ahead and updated the issue branch with the change as requested (and as I understand it).
DiegoPino
added
bug
2 participants
See #392 for 1.2.0 PR