rpc: dont log an error if user configures --rpcapi=rpc... #20776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: meows <[email protected]>
fjl
requested changes
Mar 20, 2020
rpc/endpoints.go
Outdated
| @@ -23,7 +23,7 @@ import ( | |||
| ) | |||
|
|
|||
| // checkModuleAvailability check that all names given in modules are actually | |||
| // available API services. | |||
| // available API services. It assumes that the special snowflake "rpc" module is always available. | |||
There was a problem hiding this comment.
Please reword this comment to be more neutral.
Signed-off-by: meows <[email protected]>
fjl
approved these changes
Mar 21, 2020
15 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
…0776) This just prevents a false negative ERROR warning when, for some unknown reason, a user attempts to turn on the module rpc even though it's already going to be on.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 4, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20771
I don't know... because they can? Should they know otherwise that the module is always available? Doesn't seem to be mentioned at all in https://geth.ethereum.org/docs/rpc/server.
Documentation would be helpful.
This just prevents a false negative
ERRORwarning when, for some unknown reason, a user attempts to turn on the modulerpceven though it's already going to be on.