Skip to content

rpc: dont log an error if user configures --rpcapi=rpc... #20776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2020
Merged

rpc: dont log an error if user configures --rpcapi=rpc... #20776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf13c5
rpc: dont log an error if user configures --rpcapi=rpc...
meowsbits Mar 17, 2020
bb73be8
rpc: make comment more informative and neutral
meowsbits Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rpc/endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ import (
"github.com/ethereum/go-ethereum/log"
)

// checkModuleAvailability check that all names given in modules are actually
// available API services.
// checkModuleAvailability checks that all names given in modules are actually
// available API services. It assumes that the MetadataApi module ("rpc") is always available;
// the registration of this "rpc" module happens in NewServer() and is thus common to all endpoints.
func checkModuleAvailability(modules []string, apis []API) (bad, available []string) {
availableSet := make(map[string]struct{})
for _, api := range apis {
Expand All @@ -33,7 +34,7 @@ func checkModuleAvailability(modules []string, apis []API) (bad, available []str
}
}
for _, name := range modules {
if _, ok := availableSet[name]; !ok {
if _, ok := availableSet[name]; !ok && name != MetadataApi {
bad = append(bad, name)
}
}
Expand Down