Skip to content

bob: Update to clarify ambiguity regarding shouted questions #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kytrinyx opened this issue Feb 4, 2018 · 1 comment
Closed

bob: Update to clarify ambiguity regarding shouted questions #214

kytrinyx opened this issue Feb 4, 2018 · 1 comment

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Feb 4, 2018

TL;DR: the problem specification for the Bob exercise has been updated. Consider updating the test suite for Bob to match. If you decide not to update the exercise, consider overriding description.md.


Details

The problem description for the Bob exercise lists four conditions:

  • asking a question
  • shouting
  • remaining silent
  • anything else

There's an ambiguity, however, for shouted questions: should they receive the "asking" response or the "shouting" response?

In exercism/problem-specifications#1025 this ambiguity was resolved by adding an additional rule for shouted questions.

If this track uses exercise generators to update test suites based on the canonical-data.json file from problem-specifications, then now would be a good time to regenerate 'bob'. If not, then it will require a manual update to the test case with input "WHAT THE HELL WERE YOU THINKING?".

See the most recent canonical-data.json file for the exact changes.

Remember to regenerate the exercise README after updating the test suite:

configlet generate . --only=bob --spec-path=<path to your local copy of the problem-specifications repository>

You can download the most recent configlet at https://github.com/exercism/configlet/releases/latest if you don't have it.

If, as track maintainers, you decide that you don't want to change the exercise, then please consider copying problem-specifications/exercises/bob/description.md into this track, putting it in exercises/bob/.meta/description.md and updating the description to match the current implementation. This will let us run the configlet README generation without having to worry about the bob README drifting from the implementation.

haus added a commit to haus/xclojure that referenced this issue May 5, 2018
This commit updates the bob exercise to take into account the shouting
question case, which involves updating the readme, test, and example
solution.
haus added a commit that referenced this issue May 26, 2018
Issue #214: Update bob for ambiguous case
@haus
Copy link
Contributor

haus commented May 26, 2018

Resolved with #223

@haus haus closed this as completed May 26, 2018
CrowsVeldt pushed a commit to CrowsVeldt/clojure that referenced this issue Jun 6, 2018
This commit updates the bob exercise to take into account the shouting
question case, which involves updating the readme, test, and example
solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants