Bob: Add fifth rule #1025
Merged
Bob: Add fifth rule #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new response to forcefully asked question.
Insti
reviewed
Dec 2, 2017
exercises/bob/description.md
Outdated
| @@ -4,6 +4,8 @@ Bob answers 'Sure.' if you ask him a question. | |||
|
|
|||
| He answers 'Whoa, chill out!' if you yell at him. | |||
|
|
|||
| He answers 'Calm down, I know what I'm doing!' if you question him emphaticlly. | |||
There was a problem hiding this comment.
spelling issue on this line.
Also a bit worried about complex language use here, since there are many non-english speakers.
There was a problem hiding this comment.
Yup, I see the spelling issue now. I chose emphatically because it helped to keep the line short too.
...if you yell a question at him.
should suffice.
|
I like adding a new specific non-ambiguous response for this case. 👍 Remember to bump the version number. (sorry, missclicked close button) |
1.1.0 you think? |
Removed misspelling and ended up rewodring the sentence to simplify sentence meaning.
decided to go ahead and bump to 1.1.0 after reviewing versioning criteria laid out in the repo README.
Insti
approved these changes
Dec 3, 2017
This was referenced Dec 17, 2017
petertseng
added a commit
to exercism/haskell
that referenced
this pull request
Dec 17, 2017
Closes exercism/problem-specifications#943. It was possible for a message directed to Bob to be both a question and yelling, which meant it was unclear which rule should take effect. Resolve ambiguity by simply adding a rule for that case. exercism/problem-specifications#1025
This was referenced Jan 15, 2018
This was referenced Feb 4, 2018
This was referenced Feb 4, 2018
sshine
added a commit
to exercism/sml
that referenced
this pull request
Oct 9, 2018
This includes: - 1.0.0 -> 1.1.0: "Calm down, I know what I'm doing!" in [1]. - 1.1.0 -> 1.2.0: No-op in [2] - 1.2.0 -> 1.2.1: "no letters" in [3]. - 1.2.1 -> 1.3.0: "I HATE THE DMV" in [4]. - 1.3.0 -> 1.4.0: Grammatical error in testdata in [5]. [1]: exercism/problem-specifications#1025 [2]: exercism/problem-specifications#1056 [3]: exercism/problem-specifications#1282 [4]: exercism/problem-specifications#1293 [5]: exercism/problem-specifications#1319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #943
This first commit adds a description for an emphatic question. The second commit will update the
forceful questioncase with the new response I am proposing in the description.