Skip to content

bob: Update to clarify ambiguity regarding shouted questions #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kytrinyx opened this issue Jan 15, 2018 · 0 comments
Closed

bob: Update to clarify ambiguity regarding shouted questions #1166

kytrinyx opened this issue Jan 15, 2018 · 0 comments

Comments

@kytrinyx
Copy link
Member

TL;DR: the problem specification for the Bob exercise has been updated.
Consider updating the test suite for Bob to match.
If you decide not to update the exercise, consider overriding description.md.


Details

The problem description for the Bob exercise lists four conditions:

  • asking a question
  • shouting
  • remaining silent
  • anything else

There's an ambiguity, however, for shouted questions: should they receive
the "asking" response or the "shouting" response?

In exercism/problem-specifications#1025 this ambiguity
was resolved by adding an additional rule for shouted questions.

If this track uses exercise generators to update test suites based on the
canonical-data.json file from problem-specifications, then now would be a good
time to regenerate 'bob'. If not, then it will require a manual update to the
test case with input "WHAT THE HELL WERE YOU THINKING?".

See the most recent canonical-data.json file
for the exact changes.

Remember to regenerate the exercise README after updating the test suite:

configlet generate . --only=bob --spec-path=<path to your local copy of the problem-specifications repository>

You can download the most recent configlet at https://github.com/exercism/configlet/releases/latest if you don't have it.

If, as track maintainers, you decide that you don't want to change the exercise,
then please consider copying problem-specifications/exercises/bob/description.md into this track, putting it in
exercises/bob/.meta/description.md so that we can run the configlet README generation
without having to worry about the bob README drifting from the implementation.


PS: If this is unclear, would you help me figure out how to clarify it? I'd like to submit
this issue across all of the tracks that have implemented Bob, but that have not yet updated
to include the new rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants