Skip to content

Add Largest Series Product Test Generator #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpreese opened this issue Sep 6, 2017 · 5 comments
Closed

Add Largest Series Product Test Generator #412

jpreese opened this issue Sep 6, 2017 · 5 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Sep 6, 2017 •
edited
Loading

This issue is part of an overall initiative to complete #195.

The documentation on how to add generators can be found here. If you get stuck or have any questions about adding this generator, please do not hesitate to reach out!
@felix91gr
Copy link
Contributor

felix91gr commented Sep 30, 2017 •
edited
Loading

I'll tackle this one as well!

@felix91gr
Copy link
Contributor

I finished this one as well :)
I'll wait for #471 to get merged before I open a PR though, because I branched off of that commit.

@felix91gr felix91gr mentioned this issue Oct 11, 2017
Merged
@felix91gr
Copy link
Contributor

It's here: #474

@felix91gr
Copy link
Contributor

Now that the PR's been merged, this issue can be closed :)

@jpreese
Copy link
Contributor Author

jpreese commented Oct 13, 2017

Awesome! Thanks, @felix91gr.

@jpreese jpreese closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpreese @felix91gr