-
-
Notifications
You must be signed in to change notification settings - Fork 365
Added Minesweeper generator #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Minesweeper generator #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's perfectly fine to change the input and output to use a string[]
. There are two things I thing can be improved:
- Use variables for the input and expected output. They are currently displayed inline, which leads to long sentences that are hard to read.
- Format the arrays such that they are neatly aligned on different lines. For an example, see this PR.
Thanks for doing this!
a460451
to
e03fa85
Compare
I'm done with number 1.
Now I'm on to this. |
b8c088e
to
0f4acdd
Compare
@ErikSchierboom this one's ready as well ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny comment, and then we're good to go!
{ | ||
var input = ""; | ||
var expected = ""; | ||
var input = new [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no rows should mean an empty array, not an array with an empty string. Could you replace that (also for the expected value)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
- Added generator itself - Updated generated Test file - Fixed Example and Minesweeper classes to recieve and return the right type on method Annotate. Was: string -> string. Now it is: string[] -> string[] Changed presentation on Minesweeper test suite - Inputs and Expected output are created as variables for better readability - Inputs and Expected output are formatted as multiline string arrays, for better readability. - Polish: now test suite creates strict string arrays.
0f4acdd
to
81877a7
Compare
Okay, now I've fixed and tested it. The arrays it creates now are actually better, because they are strictly Creating just Thanks for the feedback. |
Merged. Thanks! 🎉 |
@ErikSchierboom please tell me I didn't screw up by changing
Annotate
from astring -> string
function to astring[] -> string[]
one? I don't know how else to interpret the Canonical Data files.If that's allright, then this commit is pretty much cooked afaik.