Added DifferenceOfSquares generator #471
Conversation
felix91gr
force-pushed
the
adding-diff-of-squares-generator
branch
from
5199f53 to
757f286
Compare
felix91gr
changed the title
|
I finished testing this on my machine. @ErikSchierboom and @jpreese please review it :) |
|
|
| canonicalDataCase.Property = "CalculateDifferenceOfSquares"; | ||
| break; | ||
| default: | ||
| canonicalDataCase.Property = "Default_This_Shouldnt_Happen"; |
There was a problem hiding this comment.
Could you throw an exception here?
There was a problem hiding this comment.
The formatting of this switch is off (see the diff in GitHub).
There was a problem hiding this comment.
Oh. Um, that default shouldn't even exist, actually. I just put it there to debug my changes to the property names. If another property comes, and has a new name, it shouldn't make the generator throw. Since this loop is an override of the original names, it should just ignore new names that come up.
felix91gr
force-pushed
the
adding-diff-of-squares-generator
branch
from
757f286 to
5f39509
Compare
|
There we go. I removed the default. And about this...
I think I know what you mean. I've just found the diff (I was gonna ask you about it). Lemme fix it. |
felix91gr
force-pushed
the
adding-diff-of-squares-generator
branch
from
5f39509 to
0e26a45
Compare
- Changed name of class for exercise from Squares to DifferenceOfSquares, as per the standards - Changed names of methods generated in tests to fit restrictions of naming in C# (see PR exercism#442) - Changed names of methods required in exercise to fit new names generated in tests
felix91gr
force-pushed
the
adding-diff-of-squares-generator
branch
from
0e26a45 to
99c52d1
Compare
|
There we go. It was tabs v/s spaces once again. @ErikSchierboom: it's ready for revision :) |
|
Great, thanks a lot! 🎉 |
Created Generator for DifferenceOfSquares (exercism#471)
Work I have left to do is written on #442. I messed up that branch too much, so I deleted my fork and started it again.