Skip to content

Add Nucleotide Count Test Generator #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpreese opened this issue Sep 6, 2017 · 3 comments
Closed

Add Nucleotide Count Test Generator #416

jpreese opened this issue Sep 6, 2017 · 3 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Sep 6, 2017

This issue is part of an overall initiative to complete #195.

The documentation on how to add generators can be found here. If you get stuck or have any questions about adding this generator, please do not hesitate to reach out!
@hymccord
Copy link
Contributor

hymccord commented Oct 2, 2017 •
edited
Loading

I'll hop in with this one! Looking over the files, it seems to be a easy starter 😃

Only one question, the current test file includes a few tests cases that are more comprehensive than the canonical-data cases. Is it safe to assume the canonical-data file only wants those 4 tests?

@ErikSchierboom
Copy link
Member

@inkahootz Good observation! The test generators should just follow the canonical data as specific in the problem-specification repo, so if that means losing a couple of test, that is completely fine.

hymccord added a commit to hymccord/csharp that referenced this issue Oct 4, 2017
@hymccord
Add nucleotide count generator (exercism#416)
babd218 
This commit also renames the nucleotide exercise class to emulate the
rest of the exercises. I also decided to remove the count method as the
canonical data doesn't reference that this method should be tested.
ErikSchierboom pushed a commit that referenced this issue Oct 4, 2017
@hymccord @ErikSchierboom
Add Nucleotide Count Test Generator #416 (#456)
e85c9dc 
* Add nucleotide count generator (#416)

This commit also renames the nucleotide exercise class to emulate the
rest of the exercises. I also decided to remove the count method as the
canonical data doesn't reference that this method should be tested.

* Update nucleotide count example

* Fix class accessibility
@ErikSchierboom
Copy link
Member

Closed by #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErikSchierboom @hymccord @jpreese