Add Nucleotide Count Test Generator #416 #456
Conversation
This commit also renames the nucleotide exercise class to emulate the rest of the exercises. I also decided to remove the count method as the canonical data doesn't reference that this method should be tested.
|
Awesome @inkahootz! We always welcome the help 👍 As a heads up, if you haven't figured out already, the broken build is due to the fact that the class name was changed and the You can also run powershell .\build.ps1 (for windows) or build.sh (for linux) to test your build before pushing to your branch if you so desire. |
|
Ah, I forgot |
|
|
||
| namespace Generators.Exercises | ||
| { | ||
| class NucleotideCount : Exercise |
There was a problem hiding this comment.
Could you add the public modifier (for consistency)?
|
Thanks! I'll start looking for my next issue. |
|
@inkahootz There should be. I'll look into it later. I'll merge when the CI is green. |
|
Merged! Thanks a lot @inkahootz! 🎉 |
This was/is a good learning experience. I look forward to feedback and doing more work.
I tried to become as familiar as possible with the code base to come up with an elegant solution, though I didn't see a way to easily test instance properties.
As explained further in my commit message, I took the liberty to remove the Count method from the exercise. It was previously needed in he the old unit testing but with the canonical data based unit test, it was pruned.