Conversation
…eliud's eggs exercise
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@KasimKaizer Would you like to resync this from the problem spec and get it merged? |
|
@IsaacG Yes please, I would appreciate that. |
|
@KasimKaizer Go for it. Once it's updated to match the latest version of the specs (and I got merge permissions worked out), I'd be happy to merge this in. |
config.json
Outdated
| "uuid": "82fb24cc-ac33-4cce-a77a-b59ce3c77832", | ||
| "practices": [], | ||
| "prerequisites": [], | ||
| "difficulty": 4, |
There was a problem hiding this comment.
I would mark this easy, not medium.
| var tmpl = `package eliudseggs | ||
| {{.Header}} |
There was a problem hiding this comment.
| var tmpl = `package eliudseggs | |
| {{.Header}} | |
| var tmpl = `{{.Header}} |
There was a problem hiding this comment.
again, this change would break the tests
There was a problem hiding this comment.
Please rebase your PR :) The latest generator code adds the package line for you in the {{.Header}}.
use the range function Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
remove 'short mode' Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
update go version Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
No description provided.