Skip to content

Add eliuds eggs exercise#2792

Open
KasimKaizer wants to merge 13 commits intoexercism:mainfrom
KasimKaizer:add-eliuds-eggs
Open

Add eliuds eggs exercise#2792
KasimKaizer wants to merge 13 commits intoexercism:mainfrom
KasimKaizer:add-eliuds-eggs

Conversation

@KasimKaizer
Copy link

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 1, 2024
@ErikSchierboom ErikSchierboom reopened this May 2, 2024
@IsaacG
Copy link
Member

IsaacG commented Feb 22, 2026

@KasimKaizer Would you like to resync this from the problem spec and get it merged?

@KasimKaizer
Copy link
Author

@IsaacG Yes please, I would appreciate that.

@IsaacG
Copy link
Member

IsaacG commented Feb 23, 2026

@KasimKaizer Go for it. Once it's updated to match the latest version of the specs (and I got merge permissions worked out), I'd be happy to merge this in.

config.json Outdated
"uuid": "82fb24cc-ac33-4cce-a77a-b59ce3c77832",
"practices": [],
"prerequisites": [],
"difficulty": 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mark this easy, not medium.

Comment on lines +32 to +33
var tmpl = `package eliudseggs
{{.Header}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var tmpl = `package eliudseggs
{{.Header}}
var tmpl = `{{.Header}}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, this change would break the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your PR :) The latest generator code adds the package line for you in the {{.Header}}.

@IsaacG IsaacG added x:action/create Work on something from scratch x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants