-
-
Notifications
You must be signed in to change notification settings - Fork 685
[eliuds-eggs] Add new practice exercise #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b9201ed
feat(exercise): add testcases, gen.go, metadata, and a stub file for …
KasimKaizer 497708a
fix(eliuds-eggs): fix gen.go
KasimKaizer 1c6970c
update(eliuds-eegs): add test and benchmark for this exercise
KasimKaizer aa1a4a9
update(eliuds-eggs): add example.go and authors
KasimKaizer f428108
update(config): add eliud's eggs exercise
KasimKaizer 1ff7b45
Update exercises/practice/eliuds-eggs/eliuds_eggs_test.go
KasimKaizer 7e23797
Update exercises/practice/eliuds-eggs/eliuds_eggs_test.go
KasimKaizer a5937cc
Update exercises/practice/eliuds-eggs/go.mod
KasimKaizer b31c699
sync eliuds-eggs with problem spec
KasimKaizer 91776b4
add a newline to the end of eliuds-eggs's config.json
KasimKaizer c89cf04
change difficulty for eliuds-eggs from 4 to 3
KasimKaizer fa41078
Merge branch 'main' into add-eliuds-eggs
KasimKaizer da73389
change difficulty for eliuds-eggs from 4 to 3 again
KasimKaizer ea7a82b
Apply suggestion from @IsaacG
IsaacG a702d4d
Apply suggestions from code review
IsaacG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Instructions | ||
|
|
||
| Your task is to count the number of 1 bits in the binary representation of a number. | ||
|
|
||
| ## Restrictions | ||
|
|
||
| Keep your hands off that bit-count functionality provided by your standard library! | ||
| Solve this one yourself using other basic tools instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Introduction | ||
KasimKaizer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| Your friend Eliud inherited a farm from her grandma Tigist. | ||
| Her granny was an inventor and had a tendency to build things in an overly complicated manner. | ||
| The chicken coop has a digital display showing an encoded number representing the positions of all eggs that could be picked up. | ||
|
|
||
| Eliud is asking you to write a program that shows the actual number of eggs in the coop. | ||
|
|
||
| The position information encoding is calculated as follows: | ||
|
|
||
| 1. Scan the potential egg-laying spots and mark down a `1` for an existing egg or a `0` for an empty spot. | ||
| 2. Convert the number from binary to decimal. | ||
| 3. Show the result on the display. | ||
|
|
||
| Example 1: | ||
|
|
||
| ```text | ||
| Chicken Coop: | ||
| _ _ _ _ _ _ _ | ||
| |E| |E|E| | |E| | ||
|
|
||
| Resulting Binary: | ||
| 1 0 1 1 0 0 1 | ||
|
|
||
| Decimal number on the display: | ||
| 89 | ||
|
|
||
| Actual eggs in the coop: | ||
| 4 | ||
| ``` | ||
|
|
||
| Example 2: | ||
|
|
||
| ```text | ||
| Chicken Coop: | ||
| _ _ _ _ _ _ _ _ | ||
| | | | |E| | | | | | ||
|
|
||
| Resulting Binary: | ||
| 0 0 0 1 0 0 0 0 | ||
|
|
||
| Decimal number on the display: | ||
| 16 | ||
|
|
||
| Actual eggs in the coop: | ||
| 1 | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "authors": [ | ||
| "KasimKaizer" | ||
| ], | ||
| "files": { | ||
| "solution": [ | ||
| "eliuds_eggs.go" | ||
| ], | ||
| "test": [ | ||
| "eliuds_eggs_test.go" | ||
| ], | ||
| "example": [ | ||
| ".meta/example.go" | ||
| ] | ||
| }, | ||
| "blurb": "Help Eliud count the number of eggs in her chicken coop by counting the number of 1 bits in a binary representation.", | ||
| "source": "Christian Willner, Eric Willigers", | ||
| "source_url": "https://forum.exercism.org/t/new-exercise-suggestion-pop-count/7632/5" | ||
| } | ||
KasimKaizer marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Package eliudseggs contains an example solution for eliuds-eggs exercise. | ||
| package eliudseggs | ||
|
|
||
| // EggCount determines the actual egg count from the displayed value. | ||
| func EggCount(displayValue int) int { | ||
| count := 0 | ||
| for displayValue > 0 { | ||
| if (displayValue & 1) == 1 { | ||
| count++ | ||
| } | ||
| displayValue >>= 1 | ||
| } | ||
| return count | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "log" | ||
| "text/template" | ||
|
|
||
| "../../../../gen" | ||
| ) | ||
|
|
||
| func main() { | ||
| t, err := template.New("").Parse(tmpl) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| var j = map[string]interface{}{ | ||
| "eggCount": &[]testCase{}, | ||
| } | ||
| if err := gen.Gen("eliuds-eggs", j, t); err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| } | ||
|
|
||
| type testCase struct { | ||
| Description string `json:"description"` | ||
| Input struct { | ||
| Number int `json:"number"` | ||
| } `json:"input"` | ||
| Expected int `json:"expected"` | ||
| } | ||
|
|
||
| // Template to generate various test cases. | ||
| var tmpl = `package eliudseggs | ||
| {{.Header}} | ||
IsaacG marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| type testCase struct { | ||
| description string | ||
| input int | ||
| expected int | ||
| } | ||
|
|
||
| var testCases = []testCase{ | ||
| {{range .J.eggCount}}{ | ||
| description: {{printf "%q" .Description}}, | ||
| input: {{printf "%d" .Input.Number}}, | ||
| expected: {{printf "%d" .Expected}}, | ||
IsaacG marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }, | ||
| {{end}} | ||
IsaacG marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| ` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # This is an auto-generated file. | ||
| # | ||
| # Regenerating this file via `configlet sync` will: | ||
| # - Recreate every `description` key/value pair | ||
| # - Recreate every `reimplements` key/value pair, where they exist in problem-specifications | ||
| # - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) | ||
| # - Preserve any other key/value pair | ||
| # | ||
| # As user-added comments (using the # character) will be removed when this file | ||
| # is regenerated, comments can be added via a `comment` key. | ||
|
|
||
| [559e789d-07d1-4422-9004-3b699f83bca3] | ||
| description = "0 eggs" | ||
|
|
||
| [97223282-f71e-490c-92f0-b3ec9e275aba] | ||
| description = "1 egg" | ||
|
|
||
| [1f8fd18f-26e9-4144-9a0e-57cdfc4f4ff5] | ||
| description = "4 eggs" | ||
|
|
||
| [0c18be92-a498-4ef2-bcbb-28ac4b06cb81] | ||
| description = "13 eggs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package eliudseggs | ||
|
|
||
| // This is an auto-generated file. Do not change it manually. Run the generator to update the file. | ||
| // See https://github.com/exercism/go#synchronizing-tests-and-instructions | ||
| // Source: exercism/problem-specifications | ||
| // Commit: 1a96480 Add `eliuds-eggs` exercise (#2382) | ||
|
|
||
| type testCase struct { | ||
| description string | ||
| input int | ||
| expected int | ||
| } | ||
|
|
||
| var testCases = []testCase{ | ||
| { | ||
| description: "0 eggs", | ||
| input: 0, | ||
| expected: 0, | ||
| }, | ||
| { | ||
| description: "1 egg", | ||
| input: 16, | ||
| expected: 1, | ||
| }, | ||
| { | ||
| description: "4 eggs", | ||
| input: 89, | ||
| expected: 4, | ||
| }, | ||
| { | ||
| description: "13 eggs", | ||
| input: 2000000000, | ||
| expected: 13, | ||
| }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package eliudseggs | ||
|
|
||
| func EggCount(displayValue int) int { | ||
| panic("Please implement the EggCount function") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package eliudseggs | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestEggCount(t *testing.T) { | ||
| for _, tc := range testCases { | ||
| t.Run(tc.description, func(t *testing.T) { | ||
| got := EggCount(tc.input) | ||
| if got != tc.expected { | ||
| t.Fatalf("EggCount(%d) = %d, want: %d", tc.input, got, tc.expected) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkEggCount(b *testing.B) { | ||
| if testing.Short() { | ||
| b.Skip("skipping benchmark in short mode.") | ||
| } | ||
KasimKaizer marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| for i := 0; i < b.N; i++ { | ||
KasimKaizer marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| for _, tc := range testCases { | ||
| EggCount(tc.input) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module eliuds-eggs | ||
|
|
||
| go 1.18 | ||
KasimKaizer marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mark this easy, not medium.