Skip to content

Remove stub dependencies #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 8, 2016
Merged

Remove stub dependencies #423

merged 24 commits into from
Nov 8, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Nov 7, 2016

Closes #420.

@petertseng
Copy link
Member

In case you are wondering, I have to delay the review of this until about 6 hours from now.

@petertseng
Copy link
Member

But I can say this: Some of the commit messages say "unneeed" instead of "unneeded"

@petertseng
Copy link
Member

the lens-person commit is labeled largest-series-product

@rbasso
Copy link
Contributor Author

rbasso commented Nov 8, 2016

But I can say this: Some of the commit messages say "unneeed" instead of "unneeded"

Most of them are wrong. I should not commit after 2AM. 😁
Fixed. 👍

the lens-person commit is labeled largest-series-product

Thanks for finding that. 👍
Fixed.

@petertseng
Copy link
Member

Checked and things seem to build. Thanks for going through these. Interesting thing I noticed: kindergarten-garden's Data.Map requires container, but go-counting's Data.Set doesn't? That's something I didn't expect. Do you know why?

@petertseng petertseng merged commit 0e00c20 into exercism:master Nov 8, 2016
@rbasso rbasso deleted the remove-stub-dependencies branch November 8, 2016 04:30
@rbasso
Copy link
Contributor Author

rbasso commented Nov 8, 2016

I think that go-counting dependencies on containers are in the global dependencies, probably because the test suite also depends on it.

name: go-counting

dependencies:
  - base
  - containers

library:
  exposed-modules: Counting
  source-dirs: src
  dependencies:
  # - foo       # List here the packages you
  # - bar       # want to use in your solution.
    - array

tests:
  test:
    main: Tests.hs
    source-dirs: test
    dependencies:
      - go-counting
      - hspec
      - multiset

@petertseng
Copy link
Member

Closes a flaw first discovered in #189 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants