Skip to content

kindergarten-garden: "Garden can be created with just a diagram or a diagram and students." is false #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petertseng opened this issue Mar 29, 2018 · 0 comments · Fixed by #1222
Closed

kindergarten-garden: "Garden can be created with just a diagram or a diagram and students." is false #1213

petertseng opened this issue Mar 29, 2018 · 0 comments · Fixed by #1222
Labels
good first issue

Comments

@petertseng
Copy link
Member

petertseng commented Mar 29, 2018 •
edited
Loading

In https://github.com/exercism/problem-specifications/blob/master/exercises/kindergarten-garden/canonical-data.json#L5, the line "Garden can be created with just a diagram or a diagram and students." is false, because #930 removes tests that have diagram and students. All gardens are created with the diagram only.

Task:

Remove that line, and use a word in https://help.github.com/articles/closing-issues-using-keywords/ in your commit message to indicate that you have closed this issue.
mattroseman added a commit to mattroseman/problem-specifications that referenced this issue Apr 9, 2018
@mattroseman
Removed unnecessary comment in kindergarten-garden canonical-data.json
9ff41a7 
closes exercism#1213

Signed-off-by: Matthew Roseman <[email protected]>
@mattroseman mattroseman mentioned this issue Apr 9, 2018
Merged
petertseng pushed a commit that referenced this issue Apr 10, 2018
@petertseng
kindergarten-garden: Remove outdated comment in canonical-data.json (#…
07cd334 
…1222)

closes #1213

#930 removes
tests that have diagram and students. All gardens are created with the
diagram only.

Signed-off-by: Matthew Roseman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
1 participant
@petertseng