Skip to content

Kindergarten-garden: removed outdated comment in canonical-data.json #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mattroseman
Copy link
Contributor

closes #1213

Signed-off-by: Matthew Roseman [email protected]

@mattroseman mattroseman changed the title Removed unnecessary comment in kindergarten-garden canonical-data.json Kindergarten-garden: removed unnecessary comment in canonical-data.json Apr 9, 2018
Copy link
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the help @mroseman95!

@petertseng
Copy link
Member

When merging, I plan to add a few details from #1213 into the commit message. It is better to have them in the commit message than make someone have to open GitHub to see what #1213 is.

@petertseng petertseng changed the title Kindergarten-garden: removed unnecessary comment in canonical-data.json Kindergarten-garden: removed outdated comment in canonical-data.json Apr 10, 2018
@petertseng petertseng merged commit 07cd334 into exercism:master Apr 10, 2018
@petertseng
Copy link
Member

petertseng commented Apr 10, 2018

We have two approvals, and the linked issue has been open long enough that if there were any objections, people have had enough time to raise them in the issue. So I think we should merge it, without needing to wait longer.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kindergarten-garden: "Garden can be created with just a diagram or a diagram and students." is false
3 participants