Skip to content

Simplifying HighScores #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emcoding opened this issue Feb 6, 2019 · 6 comments · Fixed by #1459
Closed

Simplifying HighScores #1456

emcoding opened this issue Feb 6, 2019 · 6 comments · Fixed by #1459
Assignees

Comments

@emcoding
Copy link
Contributor

emcoding commented Feb 6, 2019

In the Ruby track, High Scores works great as an easy exercise for students, but the report method makes it a pain to mentor. We want to simplify it such that it doesn't need the giant if/else statement/extracted method/unreadable interpolation anymore.

Is this interesting for more tracks? In that case, we can change the canonical data. If it's only an issue in Ruby, we'll change it only there.

It's in @exercism/dart , @exercism/csharp @exercism/python @exercism/scala @exercism/delphi @exercism/javascript @exercism/fsharp ?
(cc @pgaspar)

@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 6, 2019

Not core (yet) for us (js/ts), but makes sense. I really like the simplicity of space-age and I think it'll helpt this as well so you can focus on the data structure instead of the formatting.

@rpottsoh
Copy link
Member

rpottsoh commented Feb 6, 2019

I am fine either way. I may leave the report cases and flag them as optional.

@ErikSchierboom
Copy link
Member

I'm also in favor of removing the report cases, for the same reasons as @SleeplessByte: it allows focusing on the data structure. It will also make reviewing/auto-approving easier.

@pgaspar
Copy link
Member

pgaspar commented Feb 6, 2019

This sounds great to me 👍 I'm ok with either removing the method entirely or finding a simpler replacement. Also found it to be a pain point for mentoring.

@emcoding
Copy link
Contributor Author

emcoding commented Feb 6, 2019

Thanks all! @pgaspar we're going to tackle this, yes?

pgaspar added a commit to pgaspar/problem-specifications that referenced this issue Feb 10, 2019
pgaspar added a commit to pgaspar/problem-specifications that referenced this issue Feb 10, 2019
@emcoding
Copy link
Contributor Author

Heads up: there's a PR up to remove the method, meaning the exercise focusses on array query methods. #1459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants