high-scores: Remove report method #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgaspar
force-pushed
the
high-scores-v4
branch
from
f02973b to
ad1f9c4
Compare
rpottsoh
approved these changes
Feb 10, 2019
|
Do we need to keep this open a bit? 24 hours? |
Closed
ErikSchierboom
approved these changes
Feb 10, 2019
|
Thanks @rpottsoh. I added the "Closes ..." on the commit itself, which I think has the same effect 🤔 I'm going to merge this shortly. Thanks everyone! |
|
You are correct. I didn't see that.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion on #1456, @F3PiX and I suggest removing the
reportmethod entirely. That's the single change in this PR.closes #1456