Skip to content

Fail the travis build if an exercise is missing critical files #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kytrinyx opened this issue Nov 29, 2016 · 6 comments
Closed

Fail the travis build if an exercise is missing critical files #457

kytrinyx opened this issue Nov 29, 2016 · 6 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Nov 29, 2016

Everything on Exercism assumes that an exercise has at the very least a description.md file and a metadata.yml file.

If one of these files is missing in an exercise, then the build should break.

See discussion here for context: exercism/DEPRECATED.trackler@036a2a7#r90053608

@rpottsoh
Copy link
Member

rpottsoh commented Nov 29, 2016 via email

@kytrinyx
Copy link
Member Author

@rpottsoh No, you only need to worry about this if you make up a completely new exercise.

kytrinyx referenced this issue in exercism/DEPRECATED.trackler Nov 29, 2016
We've never supported this, and we have tests in place to ensure
that no such exercise exists.

This commit breaks assumptions made by x-api.

This reverts commit 036a2a7.
@rpottsoh
Copy link
Member

rpottsoh commented Nov 29, 2016 via email

@tejasbubane
Copy link
Member

I am working on writing a shell script similar to https://github.com/exercism/x-common/blob/master/bin/jsonlint.

tejasbubane added a commit to tejasbubane/problem-specifications that referenced this issue Nov 29, 2016
Check for presence of `description.md` and `metadata.yml`.
Add this script to travis build.

Fixes exercism#457
tejasbubane added a commit to tejasbubane/problem-specifications that referenced this issue Nov 29, 2016
Check for presence of `description.md` and `metadata.yml`.
Add this script to travis build.

Fixes exercism#457
tejasbubane added a commit to tejasbubane/problem-specifications that referenced this issue Nov 29, 2016
Check for presence of `description.md` and `metadata.yml`.
Add this script to travis build.

Fixes exercism#457
@kytrinyx
Copy link
Member Author

@rpottsoh Ah, excellent. In that case this section of the Contributing Guide should have what you need: https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#implementing-a-completely-new-exercise

@petertseng
Copy link
Member

Please correct me if I'm wrong but I think the merging of #458 resolves this.

emcoding pushed a commit that referenced this issue Nov 19, 2018
remove superfluous `require time` from gigasecond test
emcoding pushed a commit that referenced this issue Nov 19, 2018
Regenerate the test file and update the version number.

see also: #457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants