-
-
Notifications
You must be signed in to change notification settings - Fork 556
Fail the travis build if an exercise is missing critical files #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Should I be concerned about these files at this point? Is this something I should be looking in to?
Sent from my android device.
|
@rpottsoh No, you only need to worry about this if you make up a completely new exercise. |
We've never supported this, and we have tests in place to ensure that no such exercise exists. This commit breaks assumptions made by x-api. This reverts commit 036a2a7.
@kytrinyx PR exercism/delphi#14 (Harry Potter) is not a conversion from another Exercism track. Tell me what I need to know, or at least point me in the right direction. J
|
I am working on writing a shell script similar to https://github.com/exercism/x-common/blob/master/bin/jsonlint. |
Check for presence of `description.md` and `metadata.yml`. Add this script to travis build. Fixes exercism#457
Check for presence of `description.md` and `metadata.yml`. Add this script to travis build. Fixes exercism#457
Check for presence of `description.md` and `metadata.yml`. Add this script to travis build. Fixes exercism#457
@rpottsoh Ah, excellent. In that case this section of the Contributing Guide should have what you need: https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#implementing-a-completely-new-exercise |
Please correct me if I'm wrong but I think the merging of #458 resolves this. |
remove superfluous `require time` from gigasecond test
Regenerate the test file and update the version number. see also: #457
Everything on Exercism assumes that an exercise has at the very least a
description.md
file and ametadata.yml
file.If one of these files is missing in an exercise, then the build should break.
See discussion here for context: exercism/DEPRECATED.trackler@036a2a7#r90053608
The text was updated successfully, but these errors were encountered: