Add filecheck script to check for essential files #459
Conversation
Check for presence of `description.md` and `metadata.yml`. Add this script to travis build. Fixes exercism#457
tejasbubane
force-pushed
the
filecheck
branch
from
52e6f21 to
54f2803
Compare
|
Me too :) |
|
Yikes! 🙈 |
|
❤️ ❤️ ❤️ to both of you! Let me look at both of these—and if you have an opinion on which we should merge, please speak up. |
|
I like that this prints the error to STDERR. I'm on the fence about the progress thing. I actually have a philosophical thingy around CLIs and output (which I don't adhere to strictly, but which I think about a lot). I wrote about it here: http://whipperstacker.com/2015/10/05/silence-noisy-output-from-command-line-tools-by-monitoring-progress-with-siginfo/ I think in the case of x-common and builds and things it makes sense to include it, because we're going to be running it in a context where we're impatient for it to complete. OK, @tejasbubane @Insti -- what do you think? Should we merge one or the other or combine some aspects of both? |
|
I liked @Insti's usage of |
|
Shall we merge mine? It currently mostly works, and then anyone can contribute further improvements. It's a shame we duplicated our efforts on this one. |
Yeah we should call dibs as soon as possible (note to self)
Sounds good 👍 |
|
I've added errors to STDOUT and a |
|
Closed in favor of: #458 which does essentially the same thing. Thanks for your work on this @tejasbubane, its unfortunate we both worked on the same feature at the same time. I hope I'm not out of line by merging that one and closing this, but It's been a month, and no-one else was stepping forward to make the decision. If it's wrong we can always revert and do it the other way. |
|
No worries @Insti 👍 |
Check for presence of
description.mdandmetadata.yml.Add this script to travis build.
Fixes #457