acronym: Update json for new "input" policy #1032
Conversation
| "expected": "GIMP" | ||
| }, | ||
| { | ||
| "description": "hyphenated", | ||
| "property": "abbreviate", | ||
| "phrase": "Complementary metal-oxide semiconductor", | ||
| "input": { | ||
| "phrase": "Complementary metal-oxide semiconductor" |
There was a problem hiding this comment.
minor knit pick. "phrase" should be indented a couple of spaces on last 4 cases. Otherwise, 👍
Stargator
force-pushed
the
input-acronym
branch
from
01df6bd to
622566e
Compare
|
@rpottsoh Since approved, can I merge, squash, or rebase it in? Or should I wait until one of the maintainers for problem-specifications does it? |
Stargator
changed the title
|
@Stargator I am fine either way. Others' may want to review this, but likely no one will find fault with the proposed changes in your commit. |
|
Alright, I'll give it until tomorrow night. I'm in no rush. Thanks. |
rpottsoh
changed the title
| "cases": [ | ||
| { | ||
| "description": "Abbreviate a phrase", | ||
| "cases": [ | ||
| { | ||
| "description": "basic", | ||
| "property": "abbreviate", | ||
| "phrase": "Portable Network Graphics", | ||
| "input": { | ||
| "phrase": "Portable Network Graphics" |
There was a problem hiding this comment.
This may want the same treatment that I have suggested in #1033. Do we really need a "phrase" object since it is the only item with in "input"?
There was a problem hiding this comment.
don't care what y'all decide, but #996 (comment) and #996 (comment) are explicitly in favour of having "input": {"phrase": "Portable Network Graphics"} not "input": "Portable Network Graphics" therefore that is the only thing I support in #998.
There was a problem hiding this comment.
Never mind. I agree with @petertseng.
|
@Stargator I think you can merge this when ready. |
#996 Updated the schema for canonical data. So I am updating the acronym exercise's json to reflect the change.