allergies: Update json for new "input" policy #1033
Conversation
| "input": { | ||
| "score": 2 | ||
| }, | ||
| "expected": [ |
There was a problem hiding this comment.
Do the "expected"'s need to be changed or just the the addition of "input"? I don't know that the present "expected" entries violate the schema.
There was a problem hiding this comment.
#996 Just mentions a change to input, I think expected is always one variable.
Stargator
force-pushed
the
input-allergies
branch
3 times, most recently
from
1fd903d to
7fb5996
Compare
Stargator
force-pushed
the
input-allergies
branch
from
7fb5996 to
e197c35
Compare
Stargator
changed the title
rpottsoh
changed the title
| @@ -15,7 +15,9 @@ | |||
| { | |||
| "description": "no allergies means not allergic", | |||
| "property": "allergicTo", | |||
| "score": 0, | |||
| "input": { | |||
| "score": 0 | |||
There was a problem hiding this comment.
Does "input" really need "score"? Why not just:
"input": 0,
Of course like changes for other cases. Unless we are really married to "score". Others should perhaps weigh in on this point.
Nevermind. @petertseng is right.
There was a problem hiding this comment.
don't care what y'all decide, but #996 (comment) and #996 (comment) are explicitly in favour of having "input": {"score": 0} not "input": 0 therefore that is the only thing I support in #998.
|
@Stargator I think you can go ahead and merge this when ready. |
#996 Updated the schema for canonical data. So I am updating the allergies exercise's json to reflect the change.