crypto-square: apply lowerCamelCase policy #1168
Conversation
| "cases": [ | ||
| { | ||
| "description": "empty plaintext results in an empty ciphertext", | ||
| "property": "ciphertext", | ||
| "description": "empty plainText results in an empty cipherText", |
There was a problem hiding this comment.
I assume you deliberately chose to use the property names, but I think it would maybe be better to use plain text and cipher text here.
There was a problem hiding this comment.
fixed descriptions to not use property names in text.
rpottsoh
force-pushed
the
updateCrypto-Square
branch
2 times, most recently
from
3e1a63f to
3b88936
Compare
There was a problem hiding this comment.
so, do you mind if I ask for these to remain ciphertext and plaintext?
https://en.wikipedia.org/wiki/Plain_text is significantly different from https://en.wikipedia.org/wiki/Plaintext , and I believe plaintext is more applicable to the situation at hand (cryptography).
https://en.wikipedia.org/wiki/Cipher_text redirects to https://en.wikipedia.org/wiki/Ciphertext
|
Not at all @petertseng. Thanks for the feedback. |
rpottsoh
force-pushed
the
updateCrypto-Square
branch
from
3b88936 to
2982fbd
Compare
|
@petertseng you were only referring to their use in the descriptions right? |
| "cases": [ | ||
| { | ||
| "description": "empty plaintext results in an empty ciphertext", | ||
| "property": "ciphertext", | ||
| "property": "cipherText", |
There was a problem hiding this comment.
I think ciphertext is a better property than cipherText, so I would revert this change.
| "input": { | ||
| "plaintext": "" | ||
| "plainText": "" |
There was a problem hiding this comment.
I think plaintext is a better input key than plainText, so I would revert this change.
| @@ -1,60 +1,60 @@ | |||
| { | |||
| "exercise": "crypto-square", | |||
| "version": "3.2.0", | |||
| "version": "3.2.1", | |||
| "cases": [ | |||
| { | |||
| "description": "empty plaintext results in an empty ciphertext", | |||
There was a problem hiding this comment.
I think this is good. I think "plaintext" and "ciphertext" are better in descriptions than "plain text" and "cipher text"
|
Closing this PR. Citing https://en.wikipedia.org/wiki/Plaintext. For this exercise "plaintext" and "ciphertext" are treated as single words. |
per #987