Skip to content

crypto-square: apply lowerCamelCase policy #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

crypto-square: apply lowerCamelCase policy #1168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions exercises/crypto-square/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,60 +1,60 @@
{
"exercise": "crypto-square",
"version": "3.2.0",
"version": "3.2.1",
"cases": [
{
"description": "empty plaintext results in an empty ciphertext",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. I think "plaintext" and "ciphertext" are better in descriptions than "plain text" and "cipher text"

"property": "ciphertext",
"property": "cipherText",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ciphertext is a better property than cipherText, so I would revert this change.

"input": {
"plaintext": ""
"plainText": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think plaintext is a better input key than plainText, so I would revert this change.

},
"expected": ""
},
{
"description": "Lowercase",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": "A"
"plainText": "A"
},
"expected": "a"
},
{
"description": "Remove spaces",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": " b "
"plainText": " b "
},
"expected": "b"
},
{
"description": "Remove punctuation",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": "@1,%!"
"plainText": "@1,%!"
},
"expected": "1"
},
{
"description": "9 character plaintext results in 3 chunks of 3 characters",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": "This is fun!"
"plainText": "This is fun!"
},
"expected": "tsf hiu isn"
},
{
"description": "8 character plaintext results in 3 chunks, the last one with a trailing space",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": "Chill out."
"plainText": "Chill out."
},
"expected": "clu hlt io "
},
{
"description": "54 character plaintext results in 7 chunks, the last two with trailing spaces",
"property": "ciphertext",
"property": "cipherText",
"input": {
"plaintext": "If man was meant to stay on the ground, god would have given us roots."
"plainText": "If man was meant to stay on the ground, god would have given us roots."
},
"expected": "imtgdvs fearwer mayoogo anouuio ntnnlvt wttddes aohghn sseoau "
}
Expand Down