word-count: tweak normalization test case #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In exercism/python#234 we discussed how adding a second word in the normalization case can let a track might allow some languages to use sorted counts as a normalization-agnostic assertion.
|
Looks good to me. |
kytrinyx
added a commit
that referenced
this pull request
Feb 7, 2016
word-count: tweak normalization test case
Merged
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Default name of 'world' solves the no name case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In exercism/python#234 we discussed how adding a second
word in the normalization case might allow
some languages to use sorted counts as a normalization-agnostic
assertion.
I don't know that this will work in practice as allowing people to normalize to a different case, since all the other tests have lowercase words.