-
-
Notifications
You must be signed in to change notification settings - Fork 556
Add word count cases #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add word count cases #403
Conversation
@pvcarrera it's useful to give a more complete description of the changes you are proposing here. Not everyone will be familiar with Ruby or the xruby track. |
@Insti sure, I've expanded the PR description, do you think is good enough? |
Notes for me: word-count.json was first added in #103 (I am far too lazy to figure out which tracks implemented it at the time, and it was not mentioned in #103 and so I have no insight on any decision to include or not include any cases). only update since then was #128 . Another thing I'll not have time to do is go to every track that implements word-count (and there are a lot of them) and see whether they have these cases. So all I can say is what I think from looking at the cases: The new test cases do indeed test new things, and I think they are interesting. I support their addition. |
This looks great, thank you! Maybe we can/should submit an issue to the various tracks that implement it and have each track check individually (using http://github.com/exercism/blazon). Actually, I might sit down and look through which new canonical-data.json files we've gotten that we haven't submitted issues for across the tracks, and script that up with |
In #403 the exercise was extended with a completely new aspect (*the removal of single quotations but not apostrophes*) which is not mentioned in it's minimalistic description. This removes the two related test cases to simplify this exercise.
Related to exercism/ruby#448
Add four additional test cases: