Skip to content

Add word count cases #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Conversation

pvcarrera
Copy link
Contributor

@pvcarrera pvcarrera commented Oct 10, 2016

Related to exercism/ruby#448

Add four additional test cases:

  • Handles cramped lists: Tests that words separated by commas and no spaces are counted.
  • Handles expanded lists: Tests that words separated by commas and new lines are counted.
  • With apostrophes: Checks that words with apostrophes are also counted as words.
  • With quotations: Checks that words with quotations are also counted as words.

@Insti
Copy link
Contributor

Insti commented Oct 10, 2016

@pvcarrera it's useful to give a more complete description of the changes you are proposing here. Not everyone will be familiar with Ruby or the xruby track.

@pvcarrera
Copy link
Contributor Author

pvcarrera commented Oct 10, 2016

@Insti sure, I've expanded the PR description, do you think is good enough?

@petertseng
Copy link
Member

Notes for me: word-count.json was first added in #103 (I am far too lazy to figure out which tracks implemented it at the time, and it was not mentioned in #103 and so I have no insight on any decision to include or not include any cases). only update since then was #128 . Another thing I'll not have time to do is go to every track that implements word-count (and there are a lot of them) and see whether they have these cases.

So all I can say is what I think from looking at the cases: The new test cases do indeed test new things, and I think they are interesting. I support their addition.

@kytrinyx
Copy link
Member

This looks great, thank you!

Maybe we can/should submit an issue to the various tracks that implement it and have each track check individually (using http://github.com/exercism/blazon). Actually, I might sit down and look through which new canonical-data.json files we've gotten that we haven't submitted issues for across the tracks, and script that up with good-first-patch labels.

@kytrinyx kytrinyx merged commit 8d8589f into exercism:master Oct 13, 2016
behrtam added a commit that referenced this pull request Mar 16, 2017
In #403 the exercise was extended with a completely new aspect (*the removal of single quotations but not apostrophes*) which is not mentioned in it's minimalistic description. This removes the two related test cases to simplify this exercise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants