-
-
Notifications
You must be signed in to change notification settings - Fork 556
word-count: Simplify by removing quotation aspect #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In #403 the exercise was extended with a completely new aspect (*the removal of single quotations but not apostrophes*) which is not mentioned in it's minimalistic description. This removes the two related test cases to simplify this exercise.
So basically the options are:
Personally, I don't really have an opinion either way, but perhaps other people do? |
This extension happened within the last 6 months, are we finding that there is a decrease in completion, a negative change in the discussions about the exercise, a general failure to solve these tests in solutions submitted?
|
I saw very complex implementations because they didn't know regular expressions. So they wrote a lot of if statements and accessed the the single chars of the string after they already did all the splitting and counting. |
How about keeping quotations but removing apostrophes? i.e. Change |
Contractions are common enough in documents to warrant having this included as part of the problem. It can be solved without regular expressions. It happens that regular expressions happen to be a good tool to extract that apostrophe pattern. But it isn't the only thing. Many languages support regular expressions either directly or provided through libraries, but many languages do not. Indeed, even with those using regular expressions, it seems that there are solutions with pretty complex logic. I am not sure that is a bad thing. It lets us talk about the choices for the solutions. What I would be more concerned about is a decrease in the attempt rate on this exercise. And then finding out why. |
Actually, I quite like the added apostrophe precisely because it makes the exercise just a bit more difficulty. Without this, the exercise would almost be too trivial I feel. |
I agree that this change maybe would make it too easy. So, we have the problems of Or, as most languages have some built-in functions to split on whitespace, we could just make the
But if most of you are fine with so many different problem areas in on exercise. I can deal with that, too. |
I am for not removing.... |
In #403 the exercise was extended with a completely new aspect (the removal of single quotations but not apostrophes) which is not mentioned in it's minimalistic description.
Especially in the last months we tried to simplify exercises in a way that they try to tackle at best one problem (or at least not too many different ones). Right now we test
splitting on different characters
,counting
,case normalization
andremoving some but not all punctuation
.So, I would like to see this exercise simplified just a bit by removing those two quotation test cases.