anagram: Remove comment from canonical data #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
pushed a commit
to exercism/haskell
that referenced
this pull request
Oct 5, 2018
Addresses exercism/problem-specifications#1348 The two unaccounted version bumps are no-ops: - 1.2.0 -> 1.2.1: A comment was changed in [1]. - 1.2.1 -> 1.3.0: The `property` value was changed from `anagrams` to `findAnagrams` in [2], but we call this function `anagramsFor`, so it seems that we don't aim for conformity here. [1]: exercism/problem-specifications@725b767 [2]: exercism/problem-specifications@3faf343 exercism/problem-specifications#1280 exercism/problem-specifications#1301
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Nov 1, 2018
The logical extension of Banana not being an anagram of BANANA must be that words are never anagrams of themselves, and that the test "capital word is not own anagram" only tests this for case insensitivity. 1.2.1: no-op, comment change exercism/problem-specifications#1280 1.3.0: no-op, property change exercism/problem-specifications#1301 1.4.0: case-insensitive exercism/problem-specifications#1348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is referring to a
string argument caseskey which was removed in PR #308