anagram: fix typo s/indentical/identical; rm duplicate cases; rm all "string argument" cases #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mass/last case was duplicated exactly, while the tapper/patter case was tested once with tapper as subject and once with patter as subject (I arbitrarily chose to keep the one appearing earlier in the file)
the ant -> stand, tan, at case is exactly a duplicate of a case in the "cases" section. The ant -> tan case is not a duplicate, but it does not seem to provide any extra value as the description of the test "accepts single string argument" is covered by, for example, galea -> eagle.
|
Note to myself, exercism/haskell#224 needs notification when this gets merged |
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale in individual commit messages
Closes #248 (I know #248 said it should be for newbies but I didn't see #248 when I made this PR, and saw the duplication in exercism/haskell#224 and resolved to do something about it)