Merged
Conversation
Member
|
The examples given seem to imply that the elements of the input should be transposed word-wise. For example, that: would tranpose to; If I understand the test expectations in exercism/rust#151, it appears the transposition is instead character-wise. It would be good to make this clear in the readme so that there is no confusion. especially because character-wise may indicate that is supposed to actually transpose to: which is not the same as what the example indicates. Finally, it would indeed be good to get a file with common test cases. |
Contributor
Author
|
Fixed the example to remove the ambiguity. |
transpose.md
Outdated
| is given by: | ||
|
|
||
| ``` | ||
| A D |
Contributor
|
I think this is ready. Will merge on Monday, July 18 unless someone says otherwise. |
Member
|
Thank you! |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
…as_been_improved Clock: Canonical test improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to rust implementation exercism/rust#151