-
Notifications
You must be signed in to change notification settings - Fork 544
Add transpose exercise #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome! Thanks. When adding a whole new exercise to Exercism, we need to do some additional work So, the next steps here are: [ ] Add
I'd also like to create a |
|
The testing approach here is similar to the Tournament exercise, which we recently discussed: #122 When I looked at some other implementations of Tournament, I noticed that their tests defined the inputs/outputs in-line, instead of in separate files. For example, Go. Would it make sense to do the same thing here? Is there an advantage to having large input/output files? Are they exposing edge cases that can't be exposed by smaller inputs/outputs? |
I couldn't figure out a way to make the string formatting work in-line in rust (leading spaces specifically) so I went with the file approach. |
Sweet! @andrey-gvrd do you happen to know what the licensing is on those challenges? |
@kytrinyx |
Thanks. I hope to dig into this more over the weekend. |
@andrey-gvrd OK, let's be sure to give them proper credit in the yaml file in x-common. |
... which I've checked and we're all good 👍 |
As @petertseng found in #152 and #153, tournament's output files allowed students to pass all the tests with an empty implementation. Is that the case here? Also in #152, we settled on a pretty good way of replacing the input files with inline text Could the same approach be used here to remove the need for input & output files? |
TT | ||
hh | ||
ee | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I would expect that this line would have two spaces, as the original input also has two spaces.
It looks like this one hasn't been touched for a while. If @andrey-gvrd wants to finish it up, fantastic. If not, we'll decide to either close or finish it up ourselves. From what I can see, the remaining items are
Probably also want to rebase this branch off of master so that we can add this problem in |
Thoughts on closing this one? Either that or one of us finishes it off. |
The "Address questions" item probably expands to "use the tests in https://github.com/exercism/x-common/blob/master/exercises/transpose/canonical-data.json " There are currently enough of those that I won't have the time to do this anytime soon, so it is up to our brave contributors. If anyone wishes to use these commits directly and just build on top of them feel free to check out the branch, maintaining the original author to give the credit. Or obviously one could start afresh if truly desired. |
An easy exercise based on this daily programmer challenge.
Not sure where to put the README.