Skip to content

custom-set: Make exercise schema-compliant #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2017
Merged

custom-set: Make exercise schema-compliant #672

merged 2 commits into from
Mar 10, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Mar 9, 2017

Related to #625.

},
"intersection": {
},
{
"description": "Intersect returns a set of all shared elements",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is named intersection, should we also change the description to refer to Intersection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! 😄
I just opened #674 for it. Now that we have a draft of semantic versioning, it may be a good idea to start enforcing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbasso Good point! :)

@kotp
Copy link
Member

kotp commented Mar 10, 2017

Thanks for the review @ErikSchierboom ...

@kotp kotp merged commit 4f1674e into exercism:master Mar 10, 2017
@rbasso rbasso deleted the custom-set-schema branch March 10, 2017 06:53
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Rename the global exercise hints file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants