Skip to content

custom-set: Fix description that doesn't match property name #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2017
Merged

custom-set: Fix description that doesn't match property name #674

merged 1 commit into from
Mar 10, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Mar 10, 2017

Warning: This PR is based on #672, and should not be merged before it. Only the third commit is new.

As suggested in this comment, this PR chances the a description in the canonical data, and so it also bumps the PATCH version number.

Change single test group description that doesn't match
the 'property' name 'intersection'.

Considering what is being discussed in #673,
about semantic versioning the test data, this implies a bump
in the MINOR version:

> Anything else that do not change the meaning of the tests
> should bump the PATCH version:
>
>  - Regrouping/"Renesting" test cases without changing test cases ordering.
>  - Changing descriptions or comments.
>  - Changing keys' ordering or formatting.
@rbasso rbasso requested a review from ErikSchierboom March 10, 2017 07:39
@rbasso rbasso merged commit 092749b into exercism:master Mar 10, 2017
@rbasso rbasso deleted the custom-set-fix-description branch March 10, 2017 07:51
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Normalize format of config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants