Skip to content

triangle: add parameters to exercise placeholder #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilya-khadykin opened this issue Oct 3, 2017 · 5 comments · Fixed by #761
Closed

triangle: add parameters to exercise placeholder #647

ilya-khadykin opened this issue Oct 3, 2017 · 5 comments · Fixed by #761

Comments

@ilya-khadykin
Copy link
Contributor

We would like you to help us add expected parameters in placeholder templates as described in #509 to make it easier for learners to start working on the exercise in question.

Feel free to ask any questions, we'll be glad to help!
@mikeyny mikeyny mentioned this issue Oct 3, 2017
Closed
@rozuur
Copy link
Contributor

rozuur commented Oct 6, 2017

I would like to work on this.

@ilya-khadykin
Copy link
Contributor Author

@rozuur ok, feel free to create an empty [work in progress] PR

@rozuur rozuur mentioned this issue Oct 7, 2017
Merged
@rozuur
Copy link
Contributor

rozuur commented Oct 7, 2017

@m-a-ge done

@ilya-khadykin
Copy link
Contributor Author

@rozuur I left a minor comment in your PR, please take a look

@rozuur
Copy link
Contributor

rozuur commented Oct 8, 2017

@m-a-ge I have used side_a, side_b and side_c notation instead of x,y, and z.

ilya-khadykin added a commit that referenced this issue Oct 8, 2017
@ilya-khadykin
triangle: Add parameters to exercise placeholder to fix #647
2faa00c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

triangle: Added parameters to exercise placeholder rozuur/python
2 participants
@rozuur @ilya-khadykin