triangle: Added parameters to exercise placeholder #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-khadykin
changed the title
exercises/triangle/triangle.py
Outdated
| @@ -3,5 +3,8 @@ class TriangleError(Exception): | |||
|
|
|||
|
|
|||
| class Triangle(object): | |||
| def __init__(self): | |||
| def __init__(self, x, y, z): | |||
There was a problem hiding this comment.
Honestly, I don't like single character names. Could you change them to something more meaningful
A good Python style guide from Google - https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming
There was a problem hiding this comment.
what do you propose? I have two suggestions, edge_1, edge_2, edge_3 or side_a, side_b, side_c
ilya-khadykin
suggested changes
Oct 7, 2017
rozuur
force-pushed
the
triangle-params
branch
from
19a000a to
be30622
Compare
|
@rozuur thanks for your PR Just for future reference a guide of how to write good commit messages - https://chris.beams.io/posts/git-commit/#seven-rules |
|
Thanks @m-a-ge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #647