Skip to content

hamming: update tests to version 2.0.1 #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 26, 2017
Merged

hamming: update tests to version 2.0.1 #1031

merged 9 commits into from
Oct 26, 2017

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Oct 25, 2017 •
edited
Loading

Resolves #1015

@kishan3 kishan3 mentioned this pull request Oct 25, 2017
Closed
@N-Parsons
Copy link
Contributor

If you reference the corresponding issue with Resolved #issue (eg. Resolves #1015 in this case) to your pull request description, it helps us to keep track of which issues are going to be resolved by each pull request, and avoids having multiple pull requests for an issue.

@kishan3
Copy link
Author

kishan3 commented Oct 25, 2017

Resolves #1015

@N-Parsons
Copy link
Contributor

@kishan3, I believe that the magic words need to be in the description for them to work. You can edit your description by clicking the pencil icon on the top-right of your first comment, where it currently says "No description provided.".

@kishan3
Copy link
Author

kishan3 commented Oct 25, 2017

Sure sir thank you for guidance.

@kishan3
Copy link
Author

kishan3 commented Oct 25, 2017

Hello @N-Parsons why the check is failing can you please help me understand?

N-Parsons
N-Parsons reviewed Oct 25, 2017
View reviewed changes
exercises/hamming/hamming_test.py Outdated

class HammingTest(unittest.TestCase):


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have extra whitespace in this line.

N-Parsons
N-Parsons reviewed Oct 25, 2017
View reviewed changes
exercises/hamming/hamming_test.py Outdated

def test_identical_strands(self):
self.assertEqual(hamming.distance("", ""), 0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have extra whitespace in this line.

N-Parsons
N-Parsons reviewed Oct 25, 2017
View reviewed changes
exercises/hamming/hamming_test.py Outdated

class HammingTest(unittest.TestCase):


def test_identical_strands(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function shares it's name with the one below, so it's just getting redefined without use. You need to change the name of one of these functions.

N-Parsons
N-Parsons suggested changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@N-Parsons N-Parsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can access the details for the failures by clicking "Details" next to where it says the check failed. This lets you access the log for the failed test, and generally gives good debugging information.

In your case, your code is failing the flake8 tests, meaning that there are issues with formatting and redundant code. The log can be found here: https://travis-ci.org/exercism/python/jobs/292602608

@N-Parsons N-Parsons self-assigned this Oct 25, 2017
@kishan3
Copy link
Author

kishan3 commented Oct 26, 2017

Thank you sir @N-Parsons. Will make the changes.

@kishan3 kishan3 changed the title Updated Test Version. hamming: update tests to version 2.0.1 Oct 26, 2017
@kishan3
Copy link
Author

kishan3 commented Oct 26, 2017

@N-Parsons Fixed Failing Builds Please check.

N-Parsons
N-Parsons suggested changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@N-Parsons N-Parsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like test_non_unique_character_in_first_strand should be using AAG and AAA as arguments for hamming.distance.

Similarly, test_non_unique_character_in_second_strand should be using AAA and AAG as arguments for hamming.distance.

@kishan3
Copy link
Author

kishan3 commented Oct 26, 2017 •
edited
Loading

Sure @N-Parsons. Thanks suggesting the changes.

@kishan3
Copy link
Author

kishan3 commented Oct 26, 2017

Updated.

@N-Parsons
Copy link
Contributor

Perfect! Thanks @kishan3!

@N-Parsons N-Parsons merged commit 62fda11 into exercism:master Oct 26, 2017
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 21, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031 (#2283)
ebd34ee 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 22, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031 (#2283)
b28e909 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 26, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031 (#2283)
3e41c7c 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 27, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031 (#2283)
90a8e71 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 29, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031
d93244d 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
ErikSchierboom pushed a commit to ErikSchierboom/python that referenced this pull request Jan 29, 2021
@mohanrajanr @ErikSchierboom
Implement new Concept Exercise: none exercism#1031
641664a 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
cmccandless pushed a commit that referenced this pull request Jan 29, 2021
@mohanrajanr @cmccandless
Implement new Concept Exercise: none #1031
dbe85b8 
* Added Python Concept Exercise None

* Ran Prettier for Linting

* Updated Story and new Exercises

* Review 1 None-Intro.md

* Review Changes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Parsons N-Parsons N-Parsons approved these changes

Assignees

@N-Parsons N-Parsons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishan3 @N-Parsons