Skip to content

hamming: update tests to version 2.0.1 #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 26, 2017
Merged

hamming: update tests to version 2.0.1 #1031

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c85857
Updated Test Version.
Oct 25, 2017
72d763e
Updated correct Test Version 2.0.1
Oct 25, 2017
907b8d4
Updated Tests
Oct 25, 2017
50dd2e5
Merge branch 'master' into patch-4
Oct 25, 2017
577c802
Merge branch 'master' into patch-4
Oct 26, 2017
e8f06ba
hamming: update tests to version 2.0.1
Oct 26, 2017
c7376ed
Merge branch 'master' into patch-4
Oct 26, 2017
af7e2ff
Remove redundant test.
Oct 26, 2017
0062a80
Try to fix build as per guidance.
Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions exercises/hamming/hamming_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
import hamming


# test cases adapted from `x-common//canonical-data.json` @ version: 1.0.0
# Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.1

class HammingTest(unittest.TestCase):


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have extra whitespace in this line.

def test_identical_strands(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function shares it's name with the one below, so it's just getting redefined without use. You need to change the name of one of these functions.

self.assertEqual(hamming.distance("", ""), 0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have extra whitespace in this line.

def test_identical_strands(self):
self.assertEqual(hamming.distance("A", "A"), 0)

Expand Down