poker - Update tests to match canonical-data.json @v1.0.0 #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Oct 30, 2017
There was a problem hiding this comment.
Travis-CI failed due to flake8 violations:
$ flake8
./exercises/poker/poker_test.py:7:1: E302 expected 2 blank lines, found 1
./exercises/poker/poker_test.py:16:80: E501 line too long (80 > 79 characters)
./exercises/poker/poker_test.py:160:1: E303 too many blank lines (3)
The command "flake8" failed and exited with 1 during .
exercises/poker/poker_test.py
Outdated
| @@ -2,118 +2,159 @@ | |||
|
|
|||
| from poker import poker | |||
|
|
|||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0 | |||
There was a problem hiding this comment.
Can you please add an additional line above this (2 above, 1 below) for consistency with the track?
|
Sure thing! Sorry about the delay. |
cmccandless
approved these changes
Nov 6, 2017
|
@njgingrich Merged. Congrats! Thanks for working on this! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1002.
Updated tests to match canonical data.
I renamed some tests to better match up with the json file, and some of the implementations had slightly different cards so those were matched.