Skip to content

poker: update tests to v1.1.0 #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Conversation

mrcfps
Copy link

@mrcfps mrcfps commented Feb 18, 2018

Closes #1230. Canonical Data.

  • Rename test function from poker to canonical best_hands
  • Tidy up input/output formats
  • Activate all tests (some are formerly disabled)
  • Make some test method names more meaningful

BTW I am quite confused about former contributors deactivating test cases that will break example.py by removing test_ prefix of test case methods.

* Rename test function from `poker` to canonical `best_hands`
* Tidy input/output formats
* Activate all tests (some are formerly disabled)
* Make some test method names more meaningful
@cmccandless
Copy link
Contributor

It looks like tests added in #1083 were not formatted properly. The changes still passed Travis-CI because they weren't real tests, and the reviewer (READ: myself) missed that these weren't valid tests. Good catch, @mrcfps.

@cmccandless cmccandless merged commit e0b06db into exercism:master Feb 19, 2018
@mrcfps mrcfps deleted the poker-1230 branch February 26, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poker: update tests to v1.1.0
2 participants