Skip to content

high scores: Add testing to make sure methods don't mutate the scores list #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewthetechie wants to merge 2 commits into from
Closed

high scores: Add testing to make sure methods don't mutate the scores list #1873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00430d
Add testing to make sure methods don't mutate the scores list
andrewthetechie Aug 3, 2019
e721083
Testing on the len is not enough, lets make sure they don't reorder too
andrewthetechie Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions exercises/high-scores/high_scores_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from copy import deepcopy
import unittest

from high_scores import latest, personal_best, personal_top_three
Expand All @@ -11,11 +12,24 @@ def test_latest_score(self):
expected = 30
self.assertEqual(latest(scores), expected)

def test_latest_score_doesnt_modify(self):
scores = [100, 0, 90, 30]
scores_before_call = deepcopy(scores)
latest(scores)
# test we didn't sort/reverse
self.assertEqual(scores, scores_before_call)

def test_personal_best(self):
scores = [40, 100, 70]
expected = 100
self.assertEqual(personal_best(scores), expected)

def test_personal_best_doesnt_modify(self):
scores = [40, 100, 70]
scores_before_call = deepcopy(scores)
personal_best(scores)
self.assertEqual(scores, scores_before_call)

def test_personal_top_three_from_a_list_of_scores(self):
scores = [10, 30, 90, 30, 100, 20, 10, 0, 30, 40, 40, 70, 70]
expected = [100, 90, 70]
Expand All @@ -41,6 +55,11 @@ def test_personal_top_when_there_is_only_one(self):
expected = [40]
self.assertEqual(personal_top_three(scores), expected)

def test_personal_top_doesnt_modify(self):
scores = [40, 100, 70]
scores_before_call = deepcopy(scores)
personal_top_three(scores)
self.assertEqual(scores, scores_before_call)

if __name__ == "__main__":
unittest.main()