Skip to content

high scores: Add testing to make sure methods don't mutate the scores list#1873

Closed
andrewthetechie wants to merge 2 commits intoexercism:masterfrom
andrewthetechie:master
Closed

high scores: Add testing to make sure methods don't mutate the scores list#1873
andrewthetechie wants to merge 2 commits intoexercism:masterfrom
andrewthetechie:master

Conversation

@andrewthetechie
Copy link

from a conversation in slack: https://exercism-team.slack.com/archives/CASLGCCSZ/p1564786254008900

This is a common issue we are seeing as python track mentors. This should catch students using pop to return values and doing sorts or reverse rather than sorted() or reverse()

@andrewthetechie andrewthetechie requested a review from a team as a code owner August 3, 2019 15:40
@yawpitch
Copy link
Contributor

yawpitch commented Aug 3, 2019

For anyone that comes across this we are currently considering mutation acceptable in the function-based high-scores exercise. There is a PR to update the mentor notes to reflect this here and also see prior discussion in #1868, #1745, and #1735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants