high-scores: Added new testcase for data corruption#1735
Closed
wonhyeongseo wants to merge 1 commit intoexercism:masterfrom
Closed
high-scores: Added new testcase for data corruption#1735wonhyeongseo wants to merge 1 commit intoexercism:masterfrom
wonhyeongseo wants to merge 1 commit intoexercism:masterfrom
Conversation
The current test does not check if scores is corrupted by the use of `sort` in the personal_top_three method. From checking multiple solutions and spotting this many times, and BeneKenobi wanting a test case (uuid=bf0004960b7b4ed094743ab835f1a5f4), I wrote this.
wonhyeongseo
changed the title
Contributor
|
There is a pull request in exercism/problem-specifications for this case. Whether it is within scope of the tests is under discussion there. |
Author
|
Sorry for overlooking that. I'll close the pull-request. Thank you @cmccandless! |
This was referenced Apr 9, 2019
This was referenced Aug 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test does not check if scores is corrupted by the use of
sortin the personal_top_three method. From checking multiple solutions and spotting this many times, and BeneKenobi wanting a test case (uuid=bf0004960b7b4ed094743ab835f1a5f4), I wrote this.