-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Isogram: Exercise for isogram with test cases. #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kytrinyx Kindly review my code. |
@sbulage thanks for the contribution! The build is failing with the following information in the log:
Configlet is an exercism-specific linter that checks some of the basic things about an exercise. The way to fix this is to add You can make the "difficulty" default to 1 and the "topics" an empty array. We will be filling in this information later. The "exercises" array is ordered roughly by difficulty of the exercise, so "isogram" should probably be not too early, not too late. Maybe in the second quarter of exercises somewhere. It doesn't matter too much getting it exactly right, as we can adjust this later when we get some feedback from people who solve the exercise. |
An isogram (also known as a "nonpattern word") is a word or phrase without a repeating letter. Examples of isograms: -lumberjacks -background -downstream The word isograms, however, is not an isogram, because the s repeats.
@kytrinyx Thanks for your suggestions. I made the required changes. |
For adding In addition, please add the rest of the common test cases from the x-common repo. https://github.com/exercism/x-common/blob/master/exercises/isogram/canonical-data.json The tests should all be broken up so that they test one word per test case. Look at how the other problems do it. |
@patricksjackson Sure, I will write the test cases from x-common. 👍 |
@sbulage Do you need any help completing this exercise? I'm happy to help. |
@behrtam No, Thanks :) |
A) B) from example import isogram Than you need to fix your import. I would suggest to rename your function. from isogram import is_isogram You could keep both files ( C) |
Any chance that you might find some time to finish this PR? |
Written python code which checks whether given string is isogram or not.