Skip to content

Add isogram #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2017
Merged

Add isogram #424

merged 5 commits into from
Mar 19, 2017

Conversation

behrtam
Copy link
Contributor

@behrtam behrtam commented Mar 7, 2017

This completes the work started in #367 by addressing the feedback to the previous PR. (Thanks @sbulage ❤️)

sbulage and others added 4 commits March 7, 2017 13:56
An isogram (also known as a "nonpattern word") is a word or phrase without a repeating letter.

Examples of isograms:

    -lumberjacks
    -background
    -downstream
The word isograms, however, is not an isogram, because the s repeats.
The test cases are based on the x-common canonical test data.
@sbulage
Copy link

sbulage commented Mar 7, 2017

@behrtam thanks, I couldn't make it happen in time. I was stuck for one test which is isogram True but yielding False.

@behrtam
Copy link
Contributor Author

behrtam commented Mar 7, 2017

I'm sorry, thought after 4 months you might have moved on. Next time if you have any problems, just commit the status quo and/or ask questions. Most of the time you will get help quite fast.

@rootulp
Copy link
Contributor

rootulp commented Mar 19, 2017

Looks good to me 👍

@behrtam behrtam merged commit 2e39b27 into master Mar 19, 2017
@kytrinyx kytrinyx deleted the isogram-pr branch March 19, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants