-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add annotation to skip all but first test #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f8dc45d
to
1df4f7b
Compare
8db6dae
to
00944b3
Compare
00944b3
to
d9a4aee
Compare
@m-a-ge @behrtam anything you want changed on this PR, or do you intend to merge it as is? |
I don't think this is a good idea. This just pollutes the tests and asks for manual changes of the test suit. This is something that should instead be handled by tools like |
@behrtam thanks for your response. I respectfully disagree, and hope you'll consider my point of view. I'm surprised that you're against the idea of skipping the tests, as it's a common pattern on other exercism tracks (Ruby, Java, JavaScript, C++, EcmaScript for example,) and (IMO) a fundamental piece of the TDD workflow, which is one of the core principles of exercism. Be that as it may, I do see an open issue in your backlog to 'unskip' optional tests for certain suites. The changes I made to |
I'm not "against the idea of skipping the tests" quite the contary I love the TDD flow (red - green - refactor). I'm just against polluting the test suit to do this when there are tools that can do this cleaner and nicer for you. |
@behrtam I understand. Do you want me to put the |
@behrtam on thinking about this further: I don't agree that adding the skip annotations 'pollutes' the test suite. Quite the contrary-- I think it is declarative, and conveys with better clarity to the user the intention that the tests should be approached and passed one by one. |
I'm not sure if this behavior is desired, but it's pretty common in the other exercism tracks I've seen:1. Test suite arrives to the user with only the first test enabled. All others are skipped.2. After getting the first test passing, user 'unskips' the next test.3. pass test, rinse, repeat...I implemented the change in
check_exercises.py
to 'unskip' the skipped tests for CI.If this isn't wanted, no big deal, I'll just close it. LMK!Closes #391
NB I made a change to this to use Python file methods instead of calling
sed
.