Skip to content

Update word count to match canonical tests #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matthewmorgan
Copy link

@matthewmorgan matthewmorgan commented Sep 5, 2017

Closes #445

The regex is not my favorite, but it gets the job done. Also, the tests now match the canonical data.

I also took the liberty of skipping all but the first test. If #518 gets merged, these tests will run in CI ;)

@behrtam
Copy link
Contributor

behrtam commented Sep 6, 2017

This quote stuff is somehow overcomplicating this otherwise simple exercise. I agree that a regex is the best solution in this case ... otherwise one would have to write a lot just to handle the special cases.

@matthewmorgan
Copy link
Author

@behrtam yes, the quote thing is thorny. Solving the exercise was trivial except for that.

@ilya-khadykin
Copy link
Contributor

While implementing this (or rather improving) example solution for this exercise for bash track I simply ignored the case with ' from canonical-data.json
So, it isn't necessary to include all the tests, but it's generally a good idea

Thanks for the PR, @matthewmorgan

@matthewmorgan matthewmorgan deleted the word-count branch September 8, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants