Skip to content

twelve-days: Add parameters to exercise placeholder #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2017
Merged

twelve-days: Add parameters to exercise placeholder #971

merged 3 commits into from
Oct 24, 2017

Conversation

ackerleytng
Copy link
Contributor

Fixes: #649

ilya-khadykin
ilya-khadykin suggested changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

I've left one minor comment, please take a look

exercises/twelve-days/twelve_days.py Outdated
@@ -1,8 +1,8 @@
def verse():
def verse(n):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a too ambiguous name, could it be changed to something more meaningful?

@ackerleytng
Copy link
Contributor Author

Changed n to day_number! Hope that helps.

cmccandless
cmccandless approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilya-khadykin ilya-khadykin merged commit 8111184 into exercism:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin approved these changes

@cmccandless cmccandless cmccandless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ackerleytng @ilya-khadykin @cmccandless